Skip to content

Correctly remove locks in query caches #21367

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Correctly remove locks in query caches #21367

merged 1 commit into from
Jun 22, 2020

Conversation

roji
Copy link
Member

@roji roji commented Jun 22, 2020

Fixes #21245

Thank god for continuous benchmarking...

@roji roji force-pushed the FixCompiledQueryCache branch from 21d5c30 to 0a42b54 Compare June 22, 2020 11:48
@roji roji changed the title Correctly remove lock in RelationalCommandCache Correctly remove locks in query caches Jun 22, 2020
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@roji roji merged commit 7c209ea into master Jun 22, 2020
@roji roji deleted the FixCompiledQueryCache branch June 22, 2020 15:47
@roji
Copy link
Member Author

roji commented Jun 22, 2020

😮

Yeah, this is definitely one of my issues of shame...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perf regression in query compilation
2 participants