Skip to content

Return void from AddShared and AddOwned #21741

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
1 commit merged into from
Jul 23, 2020
Merged

Return void from AddShared and AddOwned #21741

1 commit merged into from
Jul 23, 2020

Conversation

AndriySvyryd
Copy link
Member

Part of #20409

@AndriySvyryd AndriySvyryd requested a review from a team July 22, 2020 22:00
@ghost
Copy link

ghost commented Jul 22, 2020

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@AndriySvyryd
Copy link
Member Author

@msftbot Require 1 sign off

@ghost
Copy link

ghost commented Jul 22, 2020

Hello @AndriySvyryd!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

This pull request was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants