Query: Change TPT to use string discriminator column #21784

smitpatel · 2020-07-25T07:42:56Z

ghost · 2020-07-25T07:46:08Z

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

bricelam

LGTM

test/EFCore.SqlServer.FunctionalTests/Query/TPTInheritanceQuerySqlServerTest.cs

test/EFCore.SqlServer.FunctionalTests/Query/TPTFiltersInheritanceQuerySqlServerTest.cs

src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs

Feedback of #21784 Part of #21509

Query: Change TPT to use string discriminator column

8ad34a9

Part of #21509

smitpatel force-pushed the smit/tpt branch from 6d53311 to 8ad34a9 Compare July 25, 2020 07:45

smitpatel requested a review from a team July 25, 2020 07:45

smitpatel added the auto-merge label Jul 25, 2020

bricelam reviewed Jul 25, 2020

View reviewed changes

test/EFCore.SqlServer.FunctionalTests/Query/TPTInheritanceQuerySqlServerTest.cs Show resolved Hide resolved

test/EFCore.SqlServer.FunctionalTests/Query/TPTFiltersInheritanceQuerySqlServerTest.cs Show resolved Hide resolved

AndriySvyryd reviewed Jul 25, 2020

View reviewed changes

src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs Show resolved Hide resolved

AndriySvyryd approved these changes Jul 25, 2020

View reviewed changes

ghost merged commit f203e1f into main Jul 25, 2020

ghost deleted the smit/tpt branch July 25, 2020 17:28

smitpatel added a commit that referenced this pull request Jul 25, 2020

Query: Change alias of the column for TPT Discriminator

48cef48

Feedback of #21784 Part of #21509

smitpatel mentioned this pull request Jul 25, 2020

Query: Change alias of the column for TPT Discriminator #21787

Merged

smitpatel added a commit that referenced this pull request Jul 26, 2020

Query: Change alias of the column for TPT Discriminator

f02e05a

Feedback of #21784 Part of #21509

ghost pushed a commit that referenced this pull request Jul 26, 2020

Query: Change alias of the column for TPT Discriminator (#21787)

2a3ff06

Feedback of #21784 Part of #21509

ajcvickers mentioned this pull request Jul 30, 2020

Entity Framework Weekly Status Updates (2020) #19549

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Query: Change TPT to use string discriminator column #21784

Query: Change TPT to use string discriminator column #21784

smitpatel commented Jul 25, 2020

ghost commented Jul 25, 2020

bricelam left a comment

Query: Change TPT to use string discriminator column #21784

Query: Change TPT to use string discriminator column #21784

Conversation

smitpatel commented Jul 25, 2020

ghost commented Jul 25, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

bricelam left a comment

Choose a reason for hiding this comment

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.