Fix seed data inseration with ValueGeneratedOnAddOrUpdate #21865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If just given equality to `ValueGenerated.OnAdd`, the case "ValueGenerated.OnAdd | ValueGenerated.OnUpdated" is not handled properly. This is set by builder method (Fluent API) myProperty.ValueGeneratedOnAddOrUpdate() instead of .ValueGeneratedOnAdd()
If just given equality to `ValueGenerated.OnAdd`, the case "ValueGenerated.OnAdd | ValueGenerated.OnUpdated" is not handled properly. This is set by builder method (Fluent API) myProperty.ValueGeneratedOnAddOrUpdate() instead of .ValueGeneratedOnAdd()
|
If a property is generated on add and update then it shouldn't be specified in seed data, an exception is appropriate in that case |
|
Can't agree on that? Typical example: We can argue, if "updated_at" should be nullable or not, but it's a straight decision to say: |
|
@thehe Please open an issue with a small repro project that shows the problem |
|
see #21904 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If just given equality to
ValueGenerated.OnAdd, the case "ValueGenerated.OnAdd | ValueGenerated.OnUpdated" is not handled properly.This is set by builder method (Fluent API) myProperty.ValueGeneratedOnAddOrUpdate() instead of .ValueGeneratedOnAdd()