Skip to content

Add NavigationBuilder<TSource, TTarget> #22017

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
1 commit merged into from
Aug 11, 2020
Merged

Add NavigationBuilder<TSource, TTarget> #22017

1 commit merged into from
Aug 11, 2020

Conversation

AndriySvyryd
Copy link
Member

Add API consistency test to ensure generic Fluent API classes hide inherited non-generic methods

Fixes #22012
Fixes #21942

@AndriySvyryd AndriySvyryd requested a review from a team August 11, 2020 18:23
Copy link
Contributor

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were missing more than I thought we were!

Add API consistency test to ensure generic Fluent API classes hide inherited non-generic methods

Fixes #22012
Fixes #21942
@ghost
Copy link

ghost commented Aug 11, 2020

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 80583ca into main Aug 11, 2020
@ghost ghost deleted the Issue22012 branch August 11, 2020 19:53
This pull request was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants