Query: Materialize Required dependents always #22019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Aug 11, 2020
| @@ -1034,6 +1034,14 @@ private static void PopulateRowInternalForeignKeys(TableBase table) | |||
| entityTypesToVisit.Enqueue( | |||
| (referencingForeignKey.DeclaringEntityType, optional || !referencingForeignKey.IsRequiredDependent)); | |||
| } | |||
|
|
|||
| if (mainMapping.IncludesDerivedTypes) | |||
There was a problem hiding this comment.
Use the mapping for the current entityType, as other types sharing the table might be using different strategies
smitpatel
force-pushed
the
smit/requireddependent
branch
from
2274273 to
2ca3a45
Compare
AndriySvyryd
approved these changes
Aug 11, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21807
Resolves #12100