Add FK constraints between TPT tables #22136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Aug 19, 2020
src/EFCore/Metadata/Conventions/ForeignKeyPropertyDiscoveryConvention.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Aug 19, 2020
test/EFCore.SqlServer.FunctionalTests/Query/TPTInheritanceQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Aug 19, 2020
smitpatel
reviewed
Aug 20, 2020
| /// </summary> | ||
| /// <param name="foreignKey"> The foreign key. </param> | ||
| /// <returns> A value indicating whether the foreign key is defined on the primary key and pointing to the same primary key. </returns> | ||
| public static bool IsBaseLinking([NotNull] this IForeignKey foreignKey) |
There was a problem hiding this comment.
@dotnet/efteam - For new API review.
(looks fine to me)
smitpatel
approved these changes
Aug 20, 2020
Only added if there isn't an equivalent FK already in the model The new FKs are used to sort the TPT update commands instead of the ad-hoc solution Fix recursive issues exposed by the new FKs Fixes #21943
AndriySvyryd
force-pushed
the
Issue21943
branch
from
cf1aad9 to
a926a92
Compare
|
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request was closed.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only added if there isn't an equivalent FK already in the model
The new FKs are used to sort the TPT update commands instead of the ad-hoc solution
Fix recursive issues exposed by the new FKs
Fixes #21943