Skip to content

Move types out of top-level Internal namespaces #22596

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Conversation

roji
Copy link
Member

@roji roji commented Sep 18, 2020

To correspond to the interfaces which they implement, etc. Inconsistency cannot be permitted.

To correspond to the interfaces which they implement, etc.
@roji roji force-pushed the EverythingInItsPlace branch from 3bf04d6 to eac9ae2 Compare September 18, 2020 11:33
@roji roji requested a review from a team September 18, 2020 11:33
@ghost
Copy link

ghost commented Sep 18, 2020

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding an API consistency test

@roji roji merged commit 19da659 into main Sep 19, 2020
@roji roji deleted the EverythingInItsPlace branch September 19, 2020 06:29
@roji
Copy link
Member Author

roji commented Sep 19, 2020

@AndriySvyryd made a note and will look into it, thanks.

roji added a commit that referenced this pull request Sep 21, 2020
ghost pushed a commit that referenced this pull request Sep 21, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants