[release/3.1] Fix issue where property with value generated on add is reseeded in every migration #22760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…very migration Fixes #21146
ajcvickers
approved these changes
Sep 28, 2020
|
@AndriySvyryd Approved by Tactics. |
|
@AndriySvyryd - Are you planning to merge this soon? (I am assuming new branding changes went in release/3.1 so that branch is open for next patch updates) |
|
Yes, the branch is open. I was planning on going through and merging servicing-apprpoved PRs in all 4 repos once I get the last branding update in (in aspnetcore-tooling), but since this repo has already done its branding I can get a head start by merging this one now. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21146
Description
When using
ValueGeneratedOnAddon a property that is seeded it causes redundantUpdateDatacalls in every subsequent migration to be generatedThis is porting a 5.0 fix for #21661 (a8f0f4c) to 3.1.x
Customer Impact
This issue makes generating subsequent migrations very tedious as the redundant entries need to be found and removed manually, which is error-prone.
How found
Multiple customer reports on 3.1.6.
Test coverage
This PR adds a test for the affected scenario.
Regression?
Yes, from 3.0.3
Risk
Low. The affected code path is only used for data seeding and the fix was validated in 5.0.