Skip to content

[TINY] Fix to #23121 - Query: improve optimization of "false==(expr)" #23239

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2020
Merged

[TINY] Fix to #23121 - Query: improve optimization of "false==(expr)" #23239

merged 1 commit into from
Nov 12, 2020

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Nov 9, 2020

When optimizing false == x -> !x we were not running optimization for the Not that we just created, like we do for x == false

Fixes #23121

@maumar maumar changed the title Fix to #23121 - Query: improve optimization of "false==(expr)" [TINY] Fix to #23121 - Query: improve optimization of "false==(expr)" Nov 9, 2020
@maumar maumar requested a review from smitpatel November 9, 2020 07:28
@dmitry-lipetsk
Copy link
Contributor

Works fine :)

Thanks!

@maumar
Fix to #23121 - Query: improve optimization of "false==(expr)"
700ecb6 
When optimizing false == x -> !x we were not running optimization for the Not that we just created, like we do for x == false

Fixes #23121
@maumar maumar merged commit 700ecb6 into main Nov 12, 2020
@maumar maumar deleted the fix23121 branch November 12, 2020 05:18
@ajcvickers ajcvickers mentioned this pull request Nov 20, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query: improve optimization of "false==(expr)"
3 participants
@maumar @dmitry-lipetsk @smitpatel