Don't fixup to deleted entities #29133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new nested entity was being fixed up to the deleted double-nested entities. Fixes #29085
|
@roji If you are around, could I get a review of this? It has been approved by Tactics for RC2. |
roji
approved these changes
Sep 19, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new nested entity was being fixed up to the deleted double-nested entities.
Fixes #29085
Description
When a nested owned entity that itself has a nested owned entity is replaced and a navigation to the double-nested entity is set to null, then new nested entity is fixed up to the deleted double-nested entity.
Customer impact
The double-nested entity is not deleted when it should be, leading to incorrect data in the database.
How found
Customer reported.
Regression
No; same behavior in 6.0. We will consider porting to 6.0.
Testing
Significant testing added around double-nested owned entities.
Risk
Low; bug fix for double-nested entities.