Skip to content

Add parentheses around SQL IS NULL (7.0) #29223

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2022
Merged

Add parentheses around SQL IS NULL (7.0) #29223

merged 1 commit into from
Sep 30, 2022

Conversation

roji
Copy link
Member

@roji roji commented Sep 28, 2022

Fixes #29222

@roji roji requested a review from a team September 28, 2022 16:57
@roji roji changed the base branch from main to release/7.0 September 28, 2022 16:58
@roji
Copy link
Member Author

roji commented Sep 28, 2022 •
edited
Loading

Uh, why no checks?

@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 28, 2022

72 files changed??

@roji
Copy link
Member Author

roji commented Sep 28, 2022

72 files changed??

Yes, test only. The actual product code change is very trivial.

@roji
Copy link
Member Author

roji commented Sep 28, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbhanda rbhanda added this to the 7.0.0 milestone Sep 29, 2022
@roji roji merged commit ca31a16 into dotnet:release/7.0 Sep 30, 2022
@roji roji deleted the ParenthesesAgain branch September 30, 2022 07:33
@ajcvickers ajcvickers removed this from the 7.0.0 milestone Oct 3, 2022
@ajcvickers ajcvickers mentioned this pull request Oct 13, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EF Core 7 RC produces different translation from EF Core 6 (VB/sqlite)
4 participants
@roji @ErikEJ @ajcvickers @rbhanda