C# modernization/cleanup in database model factories #29622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikEJ
reviewed
Nov 19, 2022
src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs
Outdated
Show resolved
Hide resolved
| return command.ExecuteScalar() is string collation | ||
| ? collation | ||
| : null; | ||
| command.CommandText = "SELECT SERVERPROPERTY('Collation');"; |
There was a problem hiding this comment.
Is there a reason to have it? This is a self-contained command with a single SELECT, is there a reason to have a leading line break?
There was a problem hiding this comment.
Readability like all other statements in the class?
There was a problem hiding this comment.
Are you saying you think a leading newline improves readability in all SQL statements, or is there something special here? Because we certainly don't do it for queries, updates or anything else...
src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs
Outdated
Show resolved
Hide resolved
roji
force-pushed
the
ScaffoldingCleanup
branch
from
9a64128 to
b5e9ae6
Compare
|
@ErikEJ rebased this and added some cleanup. Can you please give this a quick review to make sure it preserves your views changes? |
|
LGTM - I will give it a spin against my CRM instance when it is in the daily build. |
ajcvickers
approved these changes
Nov 20, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.