Add NativeAOT support for Change Tracking #30256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndriySvyryd Can you go over this in the design meeting today? |
ajcvickers
reviewed
Apr 3, 2023
ajcvickers
reviewed
Apr 3, 2023
ajcvickers
approved these changes
Apr 3, 2023
|
@AndriySvyryd is it worth you going over this in a design meeting (assuming I haven't missed one where it was already done)? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept, it's still missing the compiled model generation code, this depends on #29949
Also, while there are workarounds, I ran into the following issues: dotnet/runtime#81741, dotnet/runtime#81803, dotnet/runtime#80037, dotnet/sdk#30094
Making
SaveChangescompatible with NativeAOT depends on #24896Part of #29761