Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow changing an open connection if it's not owned #30706

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

stevendarby
Copy link
Contributor

@stevendarby stevendarby commented Apr 17, 2023

Fixes #30704

I went ahead and tried something, it's fine if it's not the direction you want to take though.

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team [It's a very small change, I thought I'd try my luck]
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@ajcvickers ajcvickers merged commit 0adaa62 into dotnet:main Apr 20, 2023
@ajcvickers
Copy link
Contributor

Thanks @stevendarby!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow 'unsharing' connection between contexts
2 participants