Skip to content

[release/7.0] fixing a typo in quirk string for issue 30330 #30784

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 3, 2023

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Apr 28, 2023

No description provided.

@maumar maumar requested a review from a team April 28, 2023 00:38
@maumar
Copy link
Contributor Author

maumar commented Apr 28, 2023

@ajcvickers do we need approval for stuff like this?

@maumar maumar changed the title fixing a typo in quirk string for issue 30330 [release/7.0] fixing a typo in quirk string for issue 30330 Apr 28, 2023
@ajcvickers
Copy link
Contributor

@maumar Not sure. @danmoseley?

@wtgodbe
Copy link
Member

wtgodbe commented May 2, 2023

@danmoseley do we need tactics approval for this? It's kind of a behavioral change, but it's so trivial it feels like we could get away with tell-mode

@danmoseley
Copy link
Member

this didn't ship yet, doesn't add any risk to customers or dates, you can just merge. tactics doesn't care if we make a fix with their approval then need to follow up to fix a typo, so long as it didn't ship yet/ doesn't affect dates.

@wtgodbe wtgodbe merged commit 847bdd3 into release/7.0 May 3, 2023
@wtgodbe wtgodbe deleted the quirk_fix branch May 3, 2023 18:46
@danmoseley
Copy link
Member

@ajcvickers pointed out the the original change will ship ahead of this fix. in that case I suggest either to accept both (the code will not exist in main) or drop tactics a note to tell them.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants