-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add complex types to Metadata #31003
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
+24,162
−6,714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00d261e
to
1a5dd38
Compare
I'll be adding more tests, but this is ready to be reviewed. |
AndriySvyryd
commented
Jun 17, 2023
AndriySvyryd
commented
Jun 17, 2023
src/EFCore/Metadata/Builders/IConventionPrimitivePropertyBaseBuilder.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
commented
Jun 17, 2023
ed851d9
to
cf37185
Compare
ajcvickers
reviewed
Jun 26, 2023
src/EFCore.InMemory/ValueGeneration/Internal/InMemoryValueGeneratorSelector.cs
Show resolved
Hide resolved
ajcvickers
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐑 🇮🇹
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13947