Uncomment test output helpers everywhere #31017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So we need to see what to do with the NonShared tests - when SetTestOutputHelper is uncommented on these everything fails with "You must call await InitializeAsync("DatabaseName"); at the beginning of the test."... |
|
@maumar I reverted the uncommenting for non-shared tests for now - we can merge this for the regular tests and then look at making SetTestOutputHelper work for non-shared ones later. |
|
|
maumar
approved these changes
Jun 15, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline, @maumar.
BTW SetTestOutputHelper doesn't work with non-shared tests - at some point we can take a look at enabling that too.