Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix precompiled query handling of non-captured variables flowing in #35504

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

roji
Copy link
Member

@roji roji commented Jan 20, 2025

Fixes #35503

@roji roji requested a review from a team January 20, 2025 15:53
@@ -70,6 +70,7 @@ public async Task FullSourceTest(
using System.Linq;
using System.Linq.Expressions;
using System.Reflection;
using System.Threading;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is necessary because of this new test which references CancellationToken.

@roji roji merged commit 3f4a274 into dotnet:main Jan 23, 2025
7 checks passed
@roji roji deleted the PrecompileCapturing branch January 23, 2025 07:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompiled queries: non-captured local variables (e.g. to Skip/Take) aren't handled
2 participants