Sugar for HasForeignKey/HasPrincipalKey #6003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// The name(s) of the foreign key property(s). | ||
| /// </param> | ||
| /// <returns> The same builder instance so that multiple configuration calls can be chained. </returns> | ||
| public virtual ReferenceReferenceBuilder HasForeignKey<TDependentEntity>( |
There was a problem hiding this comment.
Should this have a class constraint to match the other APIs in CF?
|
|
| @@ -314,9 +314,15 @@ public GenericTestReferenceReferenceBuilder(ReferenceReferenceBuilder<TEntity, T | |||
| public override TestReferenceReferenceBuilder<TEntity, TRelatedEntity> HasForeignKey(Type dependentEntityType, params string[] foreignKeyPropertyNames) | |||
There was a problem hiding this comment.
The Type overload should be removed from base. The current implementation would become the implementation of the new overload in ModelBuilderNonGenericTest
ajcvickers
force-pushed
the
DarkMaster0706
branch
from
4d37958 to
498fc01
Compare
|
@AndriySvyryd Pushed an update. |
|
|
Issue #5377 Added back generic overloads so that in the common case of a shadow property in CLR entity types the generic method can be used instead of using typeof(). Also, only for these APIs, the short name of the type can be passed as a string since the resolution space is very small--it just checks the name at either end of the relationship.
ajcvickers
force-pushed
the
DarkMaster0706
branch
from
498fc01 to
53cea6f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5377
Added back generic overloads so that in the common case of a shadow property in CLR entity types the generic method can be used instead of using typeof().
Also, only for these APIs, the short name of the type can be passed as a string since the resolution space is very small--it just checks the name at either end of the relationship.