Skip to content

Commit

Permalink
Add comment about use of hashing in CachingHelpers (#5509)
Browse files Browse the repository at this point in the history
  • Loading branch information
stephentoub authored Oct 11, 2024
1 parent dbab257 commit 99fdb98
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/Libraries/Microsoft.Extensions.AI/CachingHelpers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ public static string GetCacheKey<TValue>(TValue value, bool flag, JsonSerializer
}

// The complete JSON representation is excessively long for a cache key, duplicating much of the content
// from the value. So we use a hash of it as the default key.
// from the value. So we use a hash of it as the default key, and we rely on collision resistance for security purposes.
// If a collision occurs, we'd serve the cached LLM response for a potentially unrelated prompt, leading to information
// disclosure. Use of SHA256 is an implementation detail and can be easily swapped in the future if needed, albeit
// invalidating any existing cache entries that may exist in whatever IDistributedCache was in use.
#if NET8_0_OR_GREATER
Span<byte> hashData = stackalloc byte[SHA256.HashSizeInBytes];
SHA256.HashData(jsonKeyBytes, hashData);
Expand Down

0 comments on commit 99fdb98

Please # to comment.