Removes Experimental attribute from ResilienceHandler class #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes experimental attribute from ResilienceHandler class
Adds new experimental and stable APIs to the API json file
iliar-turdushev
commented
Nov 19, 2024
amadeuszl
approved these changes
Nov 19, 2024
iliar-turdushev
commented
Nov 19, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.json
Show resolved
Hide resolved
Suppress LA0006 warning causing the build pipeline to fail
iliar-turdushev
commented
Nov 20, 2024
src/Libraries/Microsoft.Extensions.Http.Resilience/Microsoft.Extensions.Http.Resilience.csproj
Show resolved
Hide resolved
|
Approving on the assumption the @dotnet/dotnet-extensions-resilience team has done the due diligence for the API review. |
RussKie
added
area-resilience
api-approved
|
Tagging @RussKie and @joperezr as infra-area owners. The PR touches some infra files. Please, review it. Thank you.
Making the API stable was discussed there #4893 (comment). The API looks solid, I think we are good to make it stable. |
joperezr
reviewed
Nov 22, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=885446&view=codecoverage-tab |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes
Experimentalattribute from ResilienceHandler class.Fixes #5669
Microsoft Reviewers: Open in CodeFlow