Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add a few missing options to OpenAIChatclient.ToOpenAIOptions #5727

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Add a few missing options to OpenAIChatclient.ToOpenAIOptions #5727

merged 1 commit into from
Dec 9, 2024

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Dec 6, 2024 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner December 6, 2024 23:11
@stephentoub stephentoub enabled auto-merge (squash) December 6, 2024 23:12
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.OpenAI Branch 66 64.29 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Caching.Hybrid 75 86
Microsoft.Extensions.Diagnostics.Probes 70 76

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=888671&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 66 72
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 86

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=889520&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.Diagnostics.Probes 70 76
Microsoft.Extensions.Caching.Hybrid 75 77

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=889545&view=codecoverage-tab

@stephentoub stephentoub merged commit eb383d4 into dotnet:main Dec 9, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

Assignees

@stephentoub stephentoub

Labels
area-AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @dotnet-comment-bot @eiriktsarpalis