Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Feature request: Add option to --include/--exclude long list of files #699

Open
martinsuchan opened this issue Jun 8, 2020 · 11 comments
Open

Feature request: Add option to --include/--exclude long list of files #699

martinsuchan opened this issue Jun 8, 2020 · 11 comments
Labels
Documentation Help Wanted This issue is up for grabs by the community

Comments

@martinsuchan
Copy link

Right now it's possible to use the --include argument to include only specific list of files to check. This is a handy feature, but the user might hit the limit of maximum command length 32 767 characters, or 8 191 when executed from cmd.exe.
https://support.microsoft.com/en-us/help/830473/command-prompt-cmd-exe-command-line-string-limitation

Feature request: add option to specify path of a file with list of files/folders to include, or similarly to exclude. The argument name could be --includeList or --excludeList.
@jmarolf
Copy link
Contributor

jmarolf commented Jun 8, 2020

@JoeRobich can the user use a response file in this scenario?

@JoeRobich
Copy link
Member

JoeRobich commented Jun 8, 2020 •
edited
Loading

Users can use a rsp file or file globbing to help in this situation. This is an example rsp which we use during CI for validating our own formatting. It would be invoked like dotnet format @validate.rsp

@martinsuchan
Copy link
Author

The main use case why I created this feature request is the idea to use dotnet-format for checking codestyle on CI/CD machine in Merge requests or single commits.
Using this command it is possible to get the list of all changed/added files in the last commit:

git diff --name-only HEAD HEAD~1

The goal is then forwarding output from this command into dotnet-format with the --check flag.

In case of large refactorings or deeply nested source files with long relative paths it is easily possible to reach the maximum command length limit. This could be easily solved by using --includeList (or similar argument) and file with filenames.

@JoeRobich
Copy link
Member

JoeRobich commented Jun 8, 2020 •
edited
Loading

@martinsuchan Locally I ran git diff --name-only HEAD HEAD~1 > TestInclude.rsp followed by dotnet format -f --check -v diag --include @TestInclude.rsp. I think it should do the trick for you.

MachineName:format joeyrobichaud$ dotnet format -f --check -v diag --include @TestInclude.rsp
  The dotnet CLI version is '5.0.100-preview.6.20277.3'.
  Using MSBuild.exe located in '/usr/local/share/dotnet/sdk/5.0.100-preview.6.20277.3/'.
  Formatting code files in workspace '/Users/joeyrobichaud/Source/format'.
  Loading workspace.
  Complete in 1074ms.
  Determining formattable files.
  Complete in 475ms.
  Running formatters.
  Complete in 384ms.
  Formatted 0 of 3 files.
  Format complete in 1934ms.

TestInclude.rsp

src/Analyzers/AnalyzerFinderHelpers.cs
src/Analyzers/AnalyzerReferenceAnalyzerFinder.cs
src/Analyzers/Extensions.cs

@martinsuchan
Copy link
Author

@JoeRobich can you test if that works with file is >32kB?
Also that @TestInclude.rsp is some kind of PowerShell command or feature of dotnet-format?

@JoeRobich
Copy link
Member

@martinsuchan It is a feature of the command line parsing library that we use. For instance, In my post above I was running in bash. I have found an issue with large rsp files (dotnet/command-line-api#863). I will put in a PR to update to a build containing the fix.

@JoeRobich
Copy link
Member

opened #700 to pull in the fix.

@JoeRobich
Copy link
Member

JoeRobich commented Jun 8, 2020 •
edited
Loading

@martinsuchan if you would like to try with the fix merged in you can install a development build with this command - dotnet tool install -g dotnet-format --version 4.1.130802 --add-source https://dotnet.myget.org/F/format/api/v3/index.json. Using it locally I ran against a 39KB rsp generated by find ./src > TestInclude.rsp no problem.
image

Log from `dotnet format -f --check --include "@TestInclude.rsp" -v d` 
~/Source/omnisharp-roslyn [add-project-information ≡ +1 ~1 -0 !]> dotnet format -f --check --include "@TestInclude.rsp" -v d
  Formatting code files in workspace '/Users/joeyrobichaud/Source/omnisharp-roslyn'.
  omnisharp-roslyn/src/OmniSharp.Roslyn/BufferManager.cs(34,17): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn/BufferManager.cs(193,61): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Constants.cs(18,57): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Constants.cs(18,58): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Constants.cs(18,73): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Constants.cs(18,74): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/TestManager.cs(86,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/LanguageServerHost.cs(52,42): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/LanguageServerHost.cs(53,21): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/LanguageServerHost.cs(54,17): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn/Utilities/ExtensionOrderer.cs(10,191): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn/Utilities/DefaultMetadataReferencesHelper.cs(24,12): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn/Utilities/DefaultMetadataReferencesHelper.cs(25,17): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn/Utilities/DefaultMetadataReferencesHelper.cs(26,17): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn/Utilities/DefaultMetadataReferencesHelper.cs(27,17): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Shared/Utilities/ImmutableArrayExtensions.cs(17,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Utilities/LineIndexHelper.cs(47,47): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Mef/ExportProjectSystemAttribute.cs(9,46): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Mef/ExportProjectSystemAttribute.cs(12,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Services/IAssemblyLoader.cs(58,135): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Host/Protocol/RequestPacket.cs(19,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Host/Protocol/RequestPacket.cs(24,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/StructureComputer.cs(37,100): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/ExternalSourceServiceFactory.cs(30,145): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/DiscoverTestsResponse.cs(10,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/BaseTestsInContextRequest.cs(14,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/DebugTestClassGetStartInfoRequest.cs(7,54): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/BaseTestRequest.cs(9,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/BaseTestRequest.cs(13,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/Services/DiscoverTestsService.cs(29,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/Services/BaseTestService`2.cs(14,23): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.MSBuild/Models/MSBuildWorkspaceInfo.cs(15,29): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.MSBuild/ProjectFile/ProjectFileInfoExtensions.cs(105,20): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpCodeActionHandler.cs(14,53): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpCodeActionHandler.cs(48,61): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpCodeActionHandler.cs(61,66): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpCodeActionHandler.cs(89,35): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpCodeLensHandler.cs(83,59): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpCodeLensHandler.cs(92,24): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpExecuteCommandHandler.cs(19,19): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpExecuteCommandHandler.cs(19,60): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Configuration/Parser/ConfigurationTokenizer.cs(108,73): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/CakeRequestHandler.cs(21,19): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/CakeRequestHandler.cs(42,103): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/CakeRequestHandler.cs(50,15): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CSharpDiagnosticWorker.cs(28,40): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CSharpDiagnosticWorker.cs(160,19): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CSharpDiagnosticWorkerWithAnalyzers.cs(97,15): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CSharpDiagnosticWorkerWithAnalyzers.cs(165,19): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CSharpDiagnosticWorkerWithAnalyzers.cs(174,23): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CsharpDiagnosticWorkerComposer.cs(26,48): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CsharpDiagnosticWorkerComposer.cs(39,15): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/AnalyzerWorkQueue.cs(87,19): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Refactoring/FixUsingsWorker.cs(75,13): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Refactoring/FixUsingsWorker.cs(76,17): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Refactoring/FixUsingsWorker.cs(77,17): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Refactoring/FixUsingsWorker.cs(78,17): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Refactoring/FixUsingsWorker.cs(79,17): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Refactoring/FixUsingsWorker.cs(80,13): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Types/TypeLookup.cs(51,74): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Types/TypeLookup.cs(52,64): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Signatures/InvocationContext.cs(16,47): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Signatures/InvocationContext.cs(37,6): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Diagnostics/CodeCheckService.cs(43,67): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Diagnostics/ReAnalyzeService.cs(32,15): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Diagnostics/ReAnalyzeService.cs(56,15): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/Navigation/FindImplementationsHandler.cs(14,72): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/Structure/MembersAsTreeHandler.cs(14,42): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/Buffer/UpdateBufferHandler.cs(36,15): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/Buffer/UpdateBufferHandler.cs(38,24): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/MembersTree/FileMemberElement.cs(17,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/ProjectInformation/ProjectInformationRequest.cs(3,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/TypeLookup/TypeLookupRequest.cs(3,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/ReAnalyze/ReanalyzeRequest.cs(7,34): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/SignatureHelp/SignatureHelpResponse.cs(10,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/CodeAction/RunCodeActionRequest.cs(3,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/CodeAction/GetCodeActionRequest.cs(3,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/FixUsings/FixUsingsRequest.cs(3,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/Rename/RenameRequest.cs(3,1): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Refactoring/V2/BaseCodeActionService.cs(101,42): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Refactoring/V2/BaseCodeActionService.cs(104,24): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/Refactoring/V2/GetCodeActionsHandler.cs(14,42): Fix whitespace formatting.
  omnisharp-roslyn/src/OmniSharp.Roslyn/AssemblyInfo.cs(4,58): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Script/ScriptContextModelCollection.cs(14,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Shared/TransportType.cs(8,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/CakeContextModel.cs(12,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/CakeContextModelCollection.cs(14,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Roslyn/WorkspaceServices/ExtractInterfaceWorkspaceServiceFactory.cs(19,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Roslyn/WorkspaceServices/PickMemberWorkspaceService.cs(17,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Roslyn/WorkspaceServices/PickMemberWorkspaceServiceFactory.cs(19,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Roslyn/Models/ProjectInfoModel.cs(58,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Roslyn/Services/ITestCommandProvider.cs(7,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Roslyn/Services/TestContext.cs(19,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Roslyn/Services/ISyntaxFeaturesDiscover.cs(13,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Shared/Utilities/ProcessExitStatus.cs(36,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Shared/Utilities/PhysicalFileProviderExtensions.PollingFileChangeToken.cs(164,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/Configuration/KeyNormalizer.cs(15,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/Configuration/ConfigurationTokenStream.cs(64,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/Configuration/CakeConfiguration.cs(53,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/Configuration/ICakeConfiguration.cs(19,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/SyntaxFeature.cs(8,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Eventing/IEventEmitter.cs(7,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Host/Internal/ConfigurationBuilderExtensions.cs(35,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Host/Eventing/NullEventEmitter.cs(14,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Host/Services/AnalyzerAssemblyLoader.cs(325,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/GetTestStartInfoResponse.cs(9,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/DiscoverTestsResponse.cs(20,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/Configuration/Parser/ConfigurationParser.cs(106,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/Configuration/Parser/ConfigurationToken.cs(19,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/Configuration/Parser/ConfigurationTokenKind.cs(13,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Cake/Configuration/Parser/ConfigurationTokenizer.cs(111,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/SymbolLocation.cs(7,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/ProjectAnalyzeStatusMessage.cs(9,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/PackageDependency.cs(9,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/ProjectDiagnosticStatus.cs(8,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/PackageRestoreMessage.cs(8,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/UnresolvedDependenciesMessage.cs(11,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/ICsDiagnosticWorker.cs(14,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CsharpDiagnosticWorkerComposer.cs(71,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.MSBuild/Models/Events/MSBuildProjectDiagnosticsEvent.cs(13,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/TestCommand/GetTestCommandResponse.cs(8,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/TestCommand/TestCommandType.cs(7,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/ReAnalyze/ReanalyzeResponse.cs(9,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/ReAnalyze/ReanalyzeRequest.cs(10,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/SignatureHelp/SignatureHelpResponse.cs(13,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/Diagnostics/DiagnosticMessage.cs(9,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/Format/FormatRangeResponse.cs(9,2): Fix final newline.
  omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/Rename/RenameResponse.cs(16,2): Fix final newline.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/AssemblyInfo.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/BufferManager.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Script/ScriptContextModelCollection.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Shared/TransportType.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Constants.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/CakeContextModel.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/CakeContextModelCollection.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.DotNetTest/TestManager.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/LanguageServerHost.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/WorkspaceServices/ExtractInterfaceWorkspaceServiceFactory.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/WorkspaceServices/PickMemberWorkspaceService.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/WorkspaceServices/PickMemberWorkspaceServiceFactory.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/Models/ProjectInfoModel.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/Utilities/ExtensionOrderer.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/Utilities/DefaultMetadataReferencesHelper.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/Services/ITestCommandProvider.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/Services/TestContext.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn/Services/ISyntaxFeaturesDiscover.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Shared/Utilities/ProcessExitStatus.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Shared/Utilities/PhysicalFileProviderExtensions.PollingFileChangeToken.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Shared/Utilities/ImmutableArrayExtensions.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Configuration/KeyNormalizer.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Configuration/ConfigurationTokenStream.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Configuration/CakeConfiguration.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Configuration/ICakeConfiguration.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Utilities/LineIndexHelper.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Mef/ExportProjectSystemAttribute.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/SyntaxFeature.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Eventing/IEventEmitter.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Services/IAssemblyLoader.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Host/Internal/ConfigurationBuilderExtensions.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Host/Protocol/RequestPacket.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Host/Eventing/NullEventEmitter.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Host/Services/AnalyzerAssemblyLoader.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/StructureComputer.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/ExternalSourceServiceFactory.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/GetTestStartInfoResponse.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/DiscoverTestsResponse.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/BaseTestsInContextRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/DebugTestClassGetStartInfoRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.DotNetTest/Models/BaseTestRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.DotNetTest/Services/DiscoverTestsService.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.DotNetTest/Services/BaseTestService`2.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.MSBuild/Models/MSBuildWorkspaceInfo.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.MSBuild/ProjectFile/ProjectFileInfoExtensions.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpCodeActionHandler.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpCodeLensHandler.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.LanguageServerProtocol/Handlers/OmniSharpExecuteCommandHandler.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Configuration/Parser/ConfigurationParser.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Configuration/Parser/ConfigurationToken.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Configuration/Parser/ConfigurationTokenKind.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Configuration/Parser/ConfigurationTokenizer.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/CakeRequestHandler.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/SymbolLocation.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/ProjectAnalyzeStatusMessage.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/PackageDependency.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/ProjectDiagnosticStatus.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/PackageRestoreMessage.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/Events/UnresolvedDependenciesMessage.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/ICsDiagnosticWorker.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CSharpDiagnosticWorker.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CSharpDiagnosticWorkerWithAnalyzers.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CsharpDiagnosticWorkerComposer.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/AnalyzerWorkQueue.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Workers/Refactoring/FixUsingsWorker.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Types/TypeLookup.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Signatures/InvocationContext.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Diagnostics/CodeCheckService.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Diagnostics/ReAnalyzeService.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.MSBuild/Models/Events/MSBuildProjectDiagnosticsEvent.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/Navigation/FindImplementationsHandler.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/Structure/MembersAsTreeHandler.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/Buffer/UpdateBufferHandler.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/MembersTree/FileMemberElement.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/ProjectInformation/ProjectInformationRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/TypeLookup/TypeLookupRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/TestCommand/GetTestCommandResponse.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/TestCommand/TestCommandType.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/ReAnalyze/ReanalyzeResponse.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/ReAnalyze/ReanalyzeRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/SignatureHelp/SignatureHelpResponse.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/CodeAction/RunCodeActionRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/CodeAction/GetCodeActionRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/FixUsings/FixUsingsRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/Diagnostics/DiagnosticMessage.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/Format/FormatRangeResponse.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/Rename/RenameRequest.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Abstractions/Models/v1/Rename/RenameResponse.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Roslyn.CSharp/Services/Refactoring/V2/BaseCodeActionService.cs'.
  Formatted code file '/Users/joeyrobichaud/Source/omnisharp-roslyn/src/OmniSharp.Cake/Services/RequestHandlers/Refactoring/V2/GetCodeActionsHandler.cs'.
  Formatted 90 of 512 files.
  Format complete in 3206ms.

@martinsuchan
Copy link
Author

@JoeRobich this looks like a good solution for my problem. It might be a good idea to add this way of using --include and --exclude into README.md, I had no idea this syntax exists.

@JoeRobich JoeRobich added Documentation Help Wanted This issue is up for grabs by the community labels Aug 9, 2020
@chriselion chriselion mentioned this issue Jan 24, 2021
Merged
@dqwork
Copy link

dqwork commented Jan 12, 2024 •
edited
Loading

Maybe a little on the extreme end by when use an rsp file that is 134kb I get this error

System.ComponentModel.Win32Exception (206): An error occurred trying to start process 'c:\program files\dotnet\dotnet.exe' with working directory '<my_repo>'. The filename or extension is too long.
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at Microsoft.DotNet.Cli.Utils.ProcessStartInfoExtensions.Execute(ProcessStartInfo startInfo)
   at System.CommandLine.Invocation.InvocationPipeline.Invoke(ParseResult parseResult)
   at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, TimeSpan startupTime, ITelemetry telemetryClient)

@dqwork
Copy link

dqwork commented Jan 12, 2024

I'm on windows 10 using dotnet 8 sdk.

I've wittled it down to a the breaking limit - 32kb Good, 33kb it fails

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Documentation Help Wanted This issue is up for grabs by the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JoeRobich @martinsuchan @jmarolf @dqwork