-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add .pre-commit-hooks.yaml #872
Conversation
Do you need to worry about #699 for large projects? I added pre-commit support for my team's repo a few months ago (before pre-commit supported dotnet natively), and wrote the files names to a temp file before passing to |
Thanks for this @rkm! In order to merge this we will need to update the integrations.md file to talk about how you set this up. I'll review the pre-commit hook format so I can review this as best I can. NOTE: |
The |
@jmarolf Sorry for the bump, but any update on this? |
To merge this we need integrations.md to be updated to describe how someone consumed pre-commit hooks |
Ah sorry, that was a misunderstanding on my part; I interpreted
to mean that you or the other maintainers would update integrations.md. I'll see if I can push to this branch (or make another PR against it) |
Update integrations.md
@jmarolf - I updated integrations.md, and also changed the file types so that Visual Basic files will be checked too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this!
Thanks @JoeRobich! Any chance you'll be doing a release that includes this change anytime soon? I can update the integrations.md with a specific tag once it exists. |
Hi! pre-commit now supports the dotnet language natively, which is stable as of v2.9.0. This PR adds a .pre-commit-hooks.yaml file so that dotnet format can be easily integrated into the workflows of developers who use pre-commit.
A sample
.pre-commit-config.yaml
to use this hook would then look like:I'm not sure how best to document this. Many maintainers add a section in their project README which provides a sample hook like the one above. I see from #692 that there are already some notes in the
docs/integrations.md
file, which I could add this to instead?Closes #692