Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix analyzer and code fix construction #1885

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Fix analyzer and code fix construction #1885

merged 2 commits into from
Jun 27, 2023

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jun 26, 2023 •
edited
Loading

  • Replace the custom assembly loader with the one implemented in Roslyn
  • Use GetAnalyzers to retrieve analyzers
  • Ignore exceptions during extension construction

sharwell added 2 commits June 26, 2023 17:50
@sharwell
Fix analyzer and code fix construction
78a2f88 
* Use GetAnalyzers to retrieve analyzers
* Ignore exceptions during extension construction
@sharwell
Use the correct analyzer loader
b918f31
JoeRobich
JoeRobich approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to see this change.

@sharwell sharwell merged commit dd834ed into dotnet:main Jun 27, 2023
@sharwell sharwell deleted the fix-construction branch June 27, 2023 17:38
@ghost ghost added this to the Next milestone Jun 27, 2023
@sharwell sharwell mentioned this pull request Jul 25, 2023
Closed
This was referenced Feb 15, 2024
Closed
Closed
Closed
@JoeRobich JoeRobich mentioned this pull request Jul 25, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
2 participants
@sharwell @JoeRobich