-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Combine --check and --dry-run into a single option. #541
Conversation
59b79ec
to
cd0b5ef
Compare
I approve of this change. My only question is "should we bump the version number as this is a breaking change?" |
@jmarolf I plan to bump version numbers for each release. That being said. I should start doing it after a release... |
Version bump in this PR #543 |
Shouldn't this be a major version bump though? |
@jmarolf sure |
I have a GitHub Action that wraps this tool (xt0rted/dotnet-format) and I'm about to release it but was wondering how this change will effect my usage of it first. When linting I use Now that |
Hi @xt0rted, Our understanding was that --check and --dry-run were used together basically 100% of the time for the purpose of linting (once users realized they needed to have both). I would recommend checking git for unstaged changes if you are relying on the old behavior of --check. Sorry again for the change. |
The use case for
--check
(CI Validation) also uses--dry-run
. Use cases for--dry-run
could ignore exit code if formatting changes are found.Considers
--check
as the canonical flag and--dry-run
as an alias.