Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Run analyzers during integration tests #728

Merged
merged 7 commits into from
Aug 11, 2020

Conversation

JoeRobich
Copy link
Member

resolves #718

@JoeRobich JoeRobich force-pushed the analyzer-integration branch 4 times, most recently from e96a3bf to fd9d167 Compare July 9, 2020 00:13
src/dotnet-format.csproj Outdated Show resolved Hide resolved
@JoeRobich JoeRobich force-pushed the analyzer-integration branch 4 times, most recently from 2373b78 to 80218bc Compare July 9, 2020 18:00
@JoeRobich JoeRobich force-pushed the analyzer-integration branch from 80218bc to 95da645 Compare July 30, 2020 21:30
@JoeRobich
Copy link
Member Author

I imagine this would complete well before 33 minutes if the netstandard references were being added to the projects...

@JoeRobich JoeRobich force-pushed the analyzer-integration branch from 7a524c9 to b8bfffa Compare August 9, 2020 23:09
@JoeRobich
Copy link
Member Author

JoeRobich commented Aug 10, 2020

With references loading, the run time for Roslyn repo was 27 minutes. CI Integration run - https://dev.azure.com/dnceng/public/_build/results?buildId=763785&view=results

@JoeRobich JoeRobich marked this pull request as ready for review August 10, 2020 18:20
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JoeRobich JoeRobich merged commit 98c65c9 into dotnet:master Aug 11, 2020
@JoeRobich JoeRobich deleted the analyzer-integration branch March 5, 2021 21:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add analyzer fixing to integration tests
2 participants