-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove unused values from TcGlobals #17422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
psfinaki
approved these changes
Jul 23, 2024
@KevinRansom this now probably requires a manual peek after Brian's cleanup here. |
@psfinaki --- done. |
T-Gro
approved these changes
Jul 31, 2024
This was referenced Aug 13, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
NO_RELEASE_NOTES
Label for pull requests which signals, that user opted-out of providing release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused values from TcGlobals and add a TcGlobals.fsi file. There were quite a few unused values in the TcGlobals file this PR removes them.
TcGlobals is a very widely used bag of values across the compiler. The .fsi file should help the compiler limit the amount of recompilation when editing the tcglobals.fs file.
No_release notes added, because it's a minor implementation detail.