Skip to content

Account for Sealed and StructLayout attributes when checking attribute targets #17609

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 27, 2024
Merged

Account for Sealed and StructLayout attributes when checking attribute targets #17609

merged 3 commits into from
Aug 27, 2024

Conversation

edgarfgp
Copy link
Contributor

Description

Account for Sealed and StructLayout attributes when checking attribute targets

Checklist

  • Test cases added
  • Release notes entry updated

@edgarfgp edgarfgp requested a review from a team as a code owner August 26, 2024 15:26
@edgarfgp edgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii vzarytovskii enabled auto-merge (squash) August 26, 2024 17:52
psfinaki
psfinaki approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks for reducing diag noise here.

@vzarytovskii vzarytovskii merged commit 6c96fc7 into dotnet:main Aug 27, 2024
30 checks passed
This was referenced Aug 28, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Sep 14, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarfgp @vzarytovskii @psfinaki