Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Shim/file system: fix leaks of the shim #18144

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

auduchinok
Copy link
Member

Fixes the file system shim is leaked after a solution is closed:

Screenshot 2024-12-13 at 21 31 43

@auduchinok auduchinok requested a review from a team as a code owner December 13, 2024 20:35
Copy link
Contributor

github-actions bot commented Dec 13, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@auduchinok
Copy link
Member Author

We can also hide the mutable shim behind a property, so capturing the getter wouldn't be a problem.

Copy link
Member

@T-Gro T-Gro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for my understanding, did you search for all usages of " >> FileSystem" or something similar?

@T-Gro
Copy link
Member

T-Gro commented Dec 16, 2024

We can also hide the mutable shim behind a property, so capturing the getter wouldn't be a problem.

I like this encapsulation proposal more.
Avoid also future incorrect usages, not just the existing ones.

@auduchinok
Copy link
Member Author

Just for my understanding, did you search for all usages of " >> FileSystem" or something similar?

Yes, I've looked through all the usages.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants