Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add support for C# Experimental attribute #18253

Merged
merged 14 commits into from
Feb 10, 2025
Merged

Add support for C# Experimental attribute #18253

merged 14 commits into from
Feb 10, 2025

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Jan 20, 2025 •
edited
Loading

Description

Fixes #18198

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@edgarfgp edgarfgp changed the title Add support C# Experimental attribute Add support for C# Experimental attribute Jan 20, 2025
@edgarfgp edgarfgp marked this pull request as ready for review January 22, 2025 22:04
@edgarfgp edgarfgp requested a review from a team as a code owner January 22, 2025 22:04
@KevinRansom
Copy link
Member

Is there some reason this is insufficient?

https://github.com/dotnet/fsharp/blob/main/src/FSharp.Core/prim-types.fs#L265

@T-Gro
Copy link
Member

T-Gro commented Jan 24, 2025

Is there some reason this is insufficient?

https://github.com/dotnet/fsharp/blob/main/src/FSharp.Core/prim-types.fs#L265

@edgarfgp added support for detecting the same attribute which was added in .NET / supported by C#12+ - https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-12.0/experimental-attribute

@edgarfgp edgarfgp requested a review from T-Gro January 29, 2025 09:11
@edgarfgp @psfinaki
Update src/Compiler/Checking/AttributeChecking.fs
c684a36 
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
@edgarfgp edgarfgp requested a review from psfinaki February 7, 2025 12:58
@edgarfgp edgarfgp closed this Feb 9, 2025
@edgarfgp edgarfgp reopened this Feb 9, 2025
@T-Gro T-Gro enabled auto-merge (squash) February 10, 2025 11:38
psfinaki
psfinaki approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks Edgar!

@T-Gro T-Gro merged commit 8e773e7 into dotnet:main Feb 10, 2025
35 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F# compiler does not respect ExperimentalAttribute
4 participants
@edgarfgp @KevinRansom @T-Gro @psfinaki