Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Java.Interop] Ignore ListsAreStronglyTypedRule #234

Merged
merged 1 commit into from
Dec 22, 2017
Merged

[Java.Interop] Ignore ListsAreStronglyTypedRule #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions gendarme-ignore.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,6 +614,18 @@ R: Gendarme.Rules.Design.Generic.DoNotExposeGenericListsRule
# We don't care here as we don't hold the list and create it on request. So to avoid performace penalty, we keep the list as return type
M: System.Collections.Generic.List`1<Java.Interop.JniSurfacedPeerInfo> Java.Interop.JniRuntime/JniValueManager::GetSurfacedPeers()

R: Gendarme.Rules.Design.ListsAreStronglyTypedRule
# Add, Insert and Remove methods are not supported by design and thus lack strongly typed versions of these methods
T: Java.Interop.JavaBooleanArray
T: Java.Interop.JavaCharArray
T: Java.Interop.JavaDoubleArray
T: Java.Interop.JavaInt16Array
T: Java.Interop.JavaInt32Array
T: Java.Interop.JavaInt64Array
T: Java.Interop.JavaObjectArray`1
T: Java.Interop.JavaSByteArray
T: Java.Interop.JavaSingleArray

R: Gendarme.Rules.Concurrency.DoNotUseLockedRegionOutsideMethodRule
# Looks like Gendarme issue, as there are both Monitor.TryEnter and Monitor.Exit used in this method
M: System.Boolean Java.Interop.JniRuntime/JniTypeManager::TryRegisterNativeMembers(Java.Interop.JniType,System.Type,System.String)