[java-interop] Xamarin.Android host compilation fixes #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#3504 Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=2950467&view=results Commit 5fe28cd didn't go far enough. While the xamarin-android build is no longer trying to include `<mono/metadata/assembly.h>`, we get a new set of compilation errors: /Users/vsts/agent/2.155.1/work/1/s/external/Java.Interop/src/java-interop/java-interop-gc-bridge-mono.cc(34,2): error GF2D19E48: unknown type name 'MonoClass'; did you mean 'xamarin::android::MonoClass'? MonoClass *klass; ^~~~~~~~~ xamarin::android::MonoClass ../../../jni/dylib-mono.h:101:31: note: 'xamarin::android::MonoClass' declared here typedef struct _MonoClass {} MonoClass; ^ This is because the `using namespace xamarin::android` on `java-interop-gc-bridge-mono.cc` line 30 isn't evaluated, as `ANDROID` isn't defined during *host* builds of xamarin-android/src/monodroid (which builds e.g. `libmono-android.debug.*` for macOS & Windows). Add `XAMARIN_ANDROID_DYLIB_MONO` to the `#if` list, so that the `using namespace` statement is used on host builds.
grendello
approved these changes
Aug 16, 2019
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#3504
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=2950467&view=results
Commit 5fe28cd didn't go far enough. While the xamarin-android build
is no longer trying to include
<mono/metadata/assembly.h>, we get anew set of compilation errors:
This is because the
using namespace xamarin::androidonjava-interop-gc-bridge-mono.ccline 30 isn't evaluated, asANDROIDisn't defined during host builds of xamarin-android/src/monodroid
(which builds e.g.
libmono-android.debug.*for macOS & Windows).Add
XAMARIN_ANDROID_DYLIB_MONOto the#iflist, so that theusing namespacestatement is used on host builds.