[Xamarin.Android.Tools.Bytecode] Allow null enclosing method #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#3504 Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=2951424&view=ms.vss-test-web.build-test-results-tab&runId=7990780&resultId=100107&paneView=attachments The attempt to bump the Java.Interop submodule within xamarin-android hit a snag, as unit tests failed: The "ClassParse" task failed unexpectedly. System.NullReferenceException: Object reference not set to an instance of an object at Xamarin.Android.Tools.Bytecode.ClassFile.TryGetEnclosingMethodInfo (System.String& declaringClass, System.String& declaringMethod, System.String& declaringDescriptor) at Xamarin.Android.Tools.Bytecode.XmlClassDeclarationBuilder.GetEnclosingMethod () at Xamarin.Android.Tools.Bytecode.XmlClassDeclarationBuilder.ToXElement () at Xamarin.Android.Tools.Bytecode.ClassPath+<>c.<ToXElement>b__36_3 (Xamarin.Android.Tools.Bytecode.ClassFile c) at System.Linq.Enumerable+SelectIPartitionIterator`2[TSource,TResult].MoveNext () at System.Xml.Linq.XContainer.AddContentSkipNotify (System.Object content) at System.Xml.Linq.XContainer.AddContentSkipNotify (System.Object content) The cause? The [`material-menu`][0] library has `.class` files which have an `EnclosingMethod` attribute blob, but doesn't mention method name information, only an enclosing type: $ mono class-parse.exe com/balysv/material/drawable/menu/MaterialMenuDrawable\$5.class --dump ... 1: EnclosingMethod(Class(nameIndex=58 Name="com/balysv/material/drawable/menu/MaterialMenuDrawable"), ) # Behold! No method information! Support generating an XML description of this type by adding appropriate `null` checks around `EnclosingMethodAttribute`. [0]: https://repo.jfrog.org/artifactory/libs-release-bintray/com/balysv/material-menu/1.1.0/material-menu-1.1.0.aar
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#3504
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=2951424&view=ms.vss-test-web.build-test-results-tab&runId=7990780&resultId=100107&paneView=attachments
The attempt to bump the Java.Interop submodule within xamarin-android
hit a snag, as unit tests failed:
The cause? The
material-menulibrary has.classfiles whichhave an
EnclosingMethodattribute blob, but doesn't mention methodname information, only an enclosing type:
Support generating an XML description of this type by adding
appropriate
nullchecks aroundEnclosingMethodAttribute.