Skip to content

Commit

Permalink
[xharness] Generate makefile targets for non-executable projects. (#9158
Browse files Browse the repository at this point in the history 
)

It turns out some Xamarin.Mac projects are library projects (for unit tests),
and we still need to generate makefile targets for those (because we use them
to build Xamarin.Mac tests to run on older macOS bots).
  • Loading branch information
@rolfbjarne
rolfbjarne authored Jul 23, 2020
1 parent 98a4c2b commit 14d95df
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions tests/xharness/MakefileGenerator.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ public static void CreateMacMakefile (IHarness harness, IEnumerable<MacTarget> t
// special case for those targets that are auto generated from the mono assemblies
allTargets.RemoveAll (v => v.IsBCLProject);

// we can only execute executable projects
allTargets.RemoveAll (v => !v.IsExe);

// build/[install/]run targets for specific test projects.
foreach (var target in allTargets) {
var make_escaped_simplified_name = target.SimplifiedName.Replace (" ", "\\ ");
Expand Down

5 comments on commit 14d95df

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (DDFun) 🔥

Not enough free space in the host.

Pipeline on Agent XAMTESTMAC10

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (Cambridge) 🔥

Not enough free space in the host.

Pipeline on Agent XI-SCARLET-WITCH

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests tvOS (Cambridge) ❌

Device tests failed on VSTS: device tests tvOS (Cambridge).

Test results

150 tests' device not found, 0 tests passed.

Pipeline on Agent XAMTESTWIN02

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) (no summary found). 🔥

Result file /Users/xamarinqa/azdo/_work/8/s\Reports\TestSummary\TestSummary.md not found.

Pipeline on Agent XAMTESTMAC02

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥

✅ Provisioning succeeded
✅ Build succeeded
✅ Packages built successfully

View packages

✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    Search for Comparing API & creating generator diff in the log to view the complete log.
✅ Test run succeeded

Please # to comment.