[runtime] Redirect to our objc_msgSend wrapper functions when needed for .NET code. #10932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for .NET code. This makes the mono_dllmap_insert function unnecessary for .NET, so remove it. Ref: dotnet/runtime#48110 Ref: dotnet/runtime#43204 Ref: dotnet#10504
… apps due to a missing feature in the runtime. (dotnet#10123)" This reverts commit 75979ca.
spouliot
approved these changes
Mar 22, 2021
mandel-macaque
approved these changes
Mar 22, 2021
|
There's mention of mono support in dotnet/runtime#48110 (comment) @CoffeeFlux is that available in 2020-02 by any chance ? |
dalexsoto
approved these changes
Mar 22, 2021
|
@spouliot sadly no, all the CoreCLR hosting API stuff (including |
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results4 tests failed, 178 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099 |
stephen-hawley
approved these changes
Mar 23, 2021
4 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the mono_dllmap_insert function unnecessary for .NET, so remove it.
Ref: dotnet/runtime#48110
Ref: dotnet/runtime#43204
Ref: #10504