Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[release/9.0.1xx-rc1] Remove xcsync from SDK and install as .NET Global Tool #21127

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

mcumming
Copy link
Contributor

This change removes the xcsync tool as an installed component of the SDK and uses it as a .NET Global Tool. The existing targets will continue to work, they will check if the tool is already installed, and if not, install it.

Backport from: #21126

@mcumming mcumming requested a review from rolfbjarne as a code owner August 27, 2024 15:44
@mcumming mcumming requested review from dalexsoto and rolfbjarne and removed request for rolfbjarne August 27, 2024 15:44
@vs-mobiletools-engineering-service2

This comment has been minimized.

Global tools are installed so that yuou can just run the tool command, it's on the path. Local tools need to be run using `dotnet {toolname}` or `dotnet tool run {toolname}`. Also change Message to an Error and add a Warning letting the use know the tool was installed and how to remove it.

(cherry picked from commit 26bc9af)
@mcumming mcumming changed the title Remove xcsync from SDK and install as .NET Global Tool [release/9.0.1xx-rc1] Remove xcsync from SDK and install as .NET Global Tool Aug 27, 2024
Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 once fixed like the net9.0 PR.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@mcumming mcumming merged commit 41241b1 into release/9.0.1xx-rc1 Aug 28, 2024
8 of 12 checks passed
@mcumming mcumming deleted the dev/mcumming/xcsync-tool-on-9.0.1xx-rc1 branch August 28, 2024 11:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants