[msbuild/dotnet] Build binding projects on Windows instead of remotely. Fixes #16244. #21873

rolfbjarne · 2024-12-30T17:48:59Z

🚧 Work in progress, no need to review yet 🚧

Also fix design-time support for binding projects, so intellisense work
properly in referencing projects.

Fixes #16244.
Fixes #10148.
Fixes #16611.

And add an escape hatch to keep running it remotely if need be.

Instead copy each file 4 times, and add a notice to remember to update the other identical files if any of them are modified.

…API for use on Windows.

…ion logic.

rolfbjarne · 2024-12-30T17:49:03Z

/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff

azure-pipelines · 2024-12-30T17:49:26Z

Azure Pipelines successfully started running 2 pipeline(s).

vs-mobiletools-engineering-service2 · 2024-12-30T18:38:33Z

🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent
Hash: 6b7953cfd987d9739d429ad46a6187afb3b1c1fe [PR build]

rolfbjarne · 2024-12-31T09:00:03Z

/azp run xamarin-macios-pr,xamarin-macios-pr-apidiff

azure-pipelines · 2024-12-31T09:00:39Z

Azure Pipelines successfully started running 2 pipeline(s).

vs-mobiletools-engineering-service2 · 2024-12-31T09:33:28Z

🔥 [CI Build] Build failed (Detect API changes) 🔥

Build failed for the job 'Detect API changes' (with job status 'Failed')

Pipeline on Agent
Hash: 13623b6015fb8d6f9bd609f724ee3ed0cd7738ce [PR build]

vs-mobiletools-engineering-service2 · 2024-12-31T11:22:38Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 13623b6015fb8d6f9bd609f724ee3ed0cd7738ce [PR build]

vs-mobiletools-engineering-service2 · 2024-12-31T11:35:38Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 13623b6015fb8d6f9bd609f724ee3ed0cd7738ce [PR build]

vs-mobiletools-engineering-service2 · 2024-12-31T11:35:53Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 13623b6015fb8d6f9bd609f724ee3ed0cd7738ce [PR build]

vs-mobiletools-engineering-service2 · 2024-12-31T11:36:36Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 13623b6015fb8d6f9bd609f724ee3ed0cd7738ce [PR build]

vs-mobiletools-engineering-service2 · 2024-12-31T11:37:33Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 13623b6015fb8d6f9bd609f724ee3ed0cd7738ce [PR build]

vs-mobiletools-engineering-service2 · 2024-12-31T15:04:29Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 13623b6015fb8d6f9bd609f724ee3ed0cd7738ce [PR build]

vs-mobiletools-engineering-service2 · 2024-12-31T16:12:14Z

❌ [CI Build] Windows Integration Tests failed ❌

❌ Failed ❌

Pipeline on Agent
Hash: 13623b6015fb8d6f9bd609f724ee3ed0cd7738ce [PR build]

vs-mobiletools-engineering-service2 · 2024-12-31T17:51:57Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 4 tests failed, 103 tests passed.

Failures

❌ dotnettests tests (iOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (tvOS)

1 tests failed, 0 tests passed.

DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ generator tests

1 tests failed, 4 tests passed.

Roslyn Generator tests/.NET: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ msbuild tests

1 tests failed, 1 tests passed.

MSBuild tests/Tasks: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 13623b6015fb8d6f9bd609f724ee3ed0cd7738ce [PR build]

rolfbjarne added 18 commits December 30, 2024 10:20

[msbuild] Run the generator on Windows instead of remotely.

c7c04de

And add an escape hatch to keep running it remotely if need be.

[tests] Run the .NET tests involving binding projects on Windows.

a1e5a5a

[tests] Add a few more generated files to package-test-libraries.zip

de34c5d

[tests] Make code a bit more platform agnostic.

f057124

[tests] Add debug spew to track down failures on Windows.

d1ec867

[msbuild] Allow packing on Windows as well.

ba232ea

[tools] Add Windows support to PathUtils.IsSymlink.

964ba6e

[tools] Add Windows support to FileCopier.TryUpdateDirectory.

f2583ff

[tests] Don't use symlinks, it doesn't work on Windows :/

7dc0187

Instead copy each file 4 times, and add a notice to remember to update the other identical files if any of them are modified.

[tools] Improve/fix Windows support in TryUpdateDirectory.

64d6c2a

[msbuild] Create binding resource packages on Windows.

2ecc7bc

[msbuild] Do more stuff from Windows.

44fd754

[dotnet] Compute SdkIsSimulator from the RuntimeIdentifier.

d2d857d

[tests] Improve logic to find assemblies in binlogs.

d816ab5

[msbuild] Implement creating binding resource package using built-in …

f97744a

…API for use on Windows.

[msbuild] Make the Zip task work on Windows by using our own compress…

a2f61a2

…ion logic.

[tests] Improve debug output.

5cac984

[tools] Fix managed update directory.

6b7953c

rolfbjarne mentioned this pull request Dec 30, 2024

[DRAFT] Build binding projects on Windows instead of remotely. Fixes #16244. #18766

Closed

This comment has been minimized.

# to view

Don't need this.

13623b6

This comment has been minimized.

# to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[msbuild/dotnet] Build binding projects on Windows instead of remotely. Fixes #16244. #21873

[msbuild/dotnet] Build binding projects on Windows instead of remotely. Fixes #16244. #21873

rolfbjarne commented Dec 30, 2024

rolfbjarne commented Dec 30, 2024

azure-pipelines bot commented Dec 30, 2024

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 30, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Dec 31, 2024

azure-pipelines bot commented Dec 31, 2024

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 31, 2024

vs-mobiletools-engineering-service2 commented Dec 31, 2024

vs-mobiletools-engineering-service2 commented Dec 31, 2024

vs-mobiletools-engineering-service2 commented Dec 31, 2024

vs-mobiletools-engineering-service2 commented Dec 31, 2024

vs-mobiletools-engineering-service2 commented Dec 31, 2024

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 31, 2024

vs-mobiletools-engineering-service2 commented Dec 31, 2024

vs-mobiletools-engineering-service2 commented Dec 31, 2024

[msbuild/dotnet] Build binding projects on Windows instead of remotely. Fixes #16244. #21873

Are you sure you want to change the base?

[msbuild/dotnet] Build binding projects on Windows instead of remotely. Fixes #16244. #21873

Conversation

rolfbjarne commented Dec 30, 2024

rolfbjarne commented Dec 30, 2024

azure-pipelines bot commented Dec 30, 2024

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 30, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Dec 31, 2024

azure-pipelines bot commented Dec 31, 2024

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 31, 2024

🔥 [CI Build] Build failed (Detect API changes) 🔥

vs-mobiletools-engineering-service2 commented Dec 31, 2024

✅ [CI Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Dec 31, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Dec 31, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Dec 31, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

vs-mobiletools-engineering-service2 commented Dec 31, 2024

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Dec 31, 2024

✅ [CI Build] Build passed (Build packages) ✅

vs-mobiletools-engineering-service2 commented Dec 31, 2024

❌ [CI Build] Windows Integration Tests failed ❌

vs-mobiletools-engineering-service2 commented Dec 31, 2024

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ dotnettests tests (iOS)

❌ dotnettests tests (tvOS)

❌ generator tests

❌ msbuild tests

Successes