Skip to content

[GameController] Implement up to Xcode 16.3. #22699

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
May 5, 2025

Conversation

rolfbjarne
Copy link
Member

This includes some older APIs as well.

Fixes #15725.

This includes some older APIs as well.

Fixes #15725.
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.


public static bool operator != (GCPoint2 l, GCPoint2 r)
{
return l.x != r.x || l.y != r.y;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call be lazy, I would have implemented this based on the == operator.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #e9b26d6] Build passed (Build packages) ✅

Pipeline on Agent
Hash: e9b26d6410b0fe6ca0952e2e02a477df82c2852c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #e9b26d6] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: e9b26d6410b0fe6ca0952e2e02a477df82c2852c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e9b26d6410b0fe6ca0952e2e02a477df82c2852c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #e9b26d6] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: e9b26d6410b0fe6ca0952e2e02a477df82c2852c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e9b26d6] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: e9b26d6410b0fe6ca0952e2e02a477df82c2852c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e9b26d6] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: e9b26d6410b0fe6ca0952e2e02a477df82c2852c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e9b26d6] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: e9b26d6410b0fe6ca0952e2e02a477df82c2852c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #e9b26d6] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: e9b26d6410b0fe6ca0952e2e02a477df82c2852c [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #e9b26d6] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: e9b26d6410b0fe6ca0952e2e02a477df82c2852c [PR build]

@rolfbjarne rolfbjarne merged commit 131da01 into main May 5, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/xcode16.3-gamecontroller branch May 5, 2025 07:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode14 GameController.GCPhysicalInputElementCollection Strange Types
5 participants