[runtime] Remove internal memcpy p/invoke #8890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace `memcpy` with `Buffer.MemoryCopy` * Add cecil-based test to make sure we're not p/invoke into it again (nor any other MS banned API) * Remove `memcpy` from xtro ignore file
rolfbjarne
requested changes
Jun 18, 2020
| fixed (byte* arrAddr = &Maps[i].Value [0]) | ||
| Runtime.memcpy (bufferEnd, (IntPtr) arrAddr, 128); | ||
| fixed (void* arrAddr = &Maps[i].Value [0]) | ||
| Buffer.MemoryCopy ((void*) bufferEnd, arrAddr, 128, 128); |
There was a problem hiding this comment.
Buffer.MemoryCopy has the source/destination parameters reversed wrt memcpy, but they're the same order here.
A simpler change would have been to implement Runtime.memcpy using Buffer.MemoryCopy 😄
There was a problem hiding this comment.
heh, I wanted the name to disappear :)
| Runtime.memcpy (bufferEnd, (IntPtr) arrAddr, controlsSize * connectionParams.NumControlTransforms); | ||
| unsafe { | ||
| fixed (void* arrAddr = &Controls[0]) | ||
| Buffer.MemoryCopy ((void*) bufferEnd, arrAddr, controlsSize * connectionParams.NumControlTransforms, controlsSize * connectionParams.NumControlTransforms); |
There was a problem hiding this comment.
Buffer.MemoryCopy has the source/destination parameters reversed wrt memcpy, but they're the same order here.
|
Build failure Test results1 tests failed, 87 tests passed.Failed tests
|
rolfbjarne
approved these changes
Jun 19, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memcpywithBuffer.MemoryCopymemcpyfrom xtro ignore file