[Testing] Enabling some UITests from Issues folder in Appium-8 (#27182)

* removed FailsOn attributes from issues

* migrate the issues

* remove FailOn attributes

* revert changes

* update the commands

* remove the FailsOn attributes

* revert change

* added a snapshots for issues

* added snapshots

* added snapshot for issues

* added snapshot for Issue22433

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19509.cs

@@ -13,7 +13,6 @@ public Issue19509(TestDevice device) : base(device)
 		public override string Issue => "Entry TextColor property not working when the Text value is bound after some time";
 
 		[Test]
-		[FailsOnMacWhenRunningOnXamarinUITest("VerifyScreenshot method not implemented on macOS")]
 		[Category(UITestCategories.Entry)]
 		public async Task EntryTextColorStopsWorkingAfterPropertyIsUpdatedFromBinding()
 		{

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20156.cs

@@ -14,7 +14,6 @@ public Issue20156(TestDevice device)
 
 	[Test]
 	[Category(UITestCategories.Border)]
-	[FailsOnMacWhenRunningOnXamarinUITest("VerifyScreenshot method not implemented on macOS")]
 	public void BorderShouldHaveNoThickness()
 	{
 		_ = App.WaitForElement("WaitForStubControl");

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22433.cs

@@ -1,5 +1,4 @@
-#if TEST_FAILS_ON_CATALYST
-using NUnit.Framework;
+using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
 
@@ -36,4 +35,3 @@ public async Task ButtonLayoutAndSpacingTests()
 		}
 	}
 }
-#endif

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23158.cs

@@ -12,7 +12,6 @@ public Issue23158(TestDevice device) : base(device)
 	{
 	}
 
-#if !MACCATALYST
 	[Test]
 	[Category(UITestCategories.Entry)]
 	public void ValidateEntryClearButtonVisibilityBehavior()
@@ -33,5 +32,4 @@ public void ValidateEntryClearButtonVisibilityBehavior()
 
 		VerifyScreenshot();
 	}
-#endif
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24574.cs

@@ -13,7 +13,6 @@ public Issue24574(TestDevice testDevice) : base(testDevice)
 		public override string Issue => "Tap Double Tap";
 
 		[Test]
-		[FailsOnMacWhenRunningOnXamarinUITest]
 		[Category(UITestCategories.Gestures)]
 		[Category(UITestCategories.Compatibility)]
 		public void TapThenDoubleTap()
@@ -23,10 +22,10 @@ public void TapThenDoubleTap()
 			App.WaitForElement("TapLabel");
 
 			App.Tap("TapLabel");
-			App.WaitForNoElement("Single");
+			App.WaitForElement("Single");
 
 			App.DoubleTap("TapLabel");
-			App.WaitForNoElement("Double");
+			App.WaitForElement("Double");
 		}
 	}
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24583.cs

@@ -1,5 +1,4 @@
-#if TEST_FAILS_ON_CATALYST
-using NUnit.Framework;
+using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
 
@@ -21,5 +20,4 @@ public void TextInEditorShouldBeCorrectlyPositionedAfterResizing()
 		App.Click("button");
 		VerifyScreenshot("TextsInEditorsAfterScaling");
 	}
-}
-#endif
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3049.cs

@@ -1,4 +1,5 @@
-#if IOS
+# if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS
+// The DisplayActionSheet will not dismiss when tapping outside of it, which is a behavior specific to iPads on iOS. Since the host app is running on an iPhone XS, this test can be ignored.
 using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
@@ -9,9 +10,7 @@ public class Issue3049 : _IssuesUITest
 	{
 		const string Button1Id = "button1";
 		const string Button2Id = "button2";
-		const string LabelId = "label";
 		const string Success = "Success";
-		const string Action1 = "Don't click me";
 
 		public Issue3049(TestDevice testDevice) : base(testDevice)
 		{
@@ -22,18 +21,17 @@ public Issue3049(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.DisplayAlert)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
+		[FailsOnIOSWhenRunningOnXamarinUITest("Skip this test -- as it is not applicable since the host app is not run on iPad in CI")]
 		public async Task Issue3049Test()
 		{
 			App.WaitForElement(Button1Id);
 
 			App.Tap(Button1Id);
 
 			await Task.Delay(500);
-			//App.WaitForElement(Action1);
 
 			// Tap outside ActionSheet to dismiss it
-			App.Tap(LabelId);
+			App.TapCoordinates(50, 100);
 
 			App.WaitForElement(Button2Id);
 			App.Tap(Button2Id);

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3087.cs

@@ -1,5 +1,4 @@
-#if ANDROID
-using NUnit.Framework;
+using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
 
@@ -18,8 +17,7 @@ public Issue3087(TestDevice testDevice) : base(testDevice)
 		[Category(UITestCategories.Compatibility)]
 		public void NonAppCompatBasicSwitchTest()
 		{
-			App.WaitForNoElement("Success");
+			App.WaitForElement("Success");
 		}
 	}
-}
-#endif
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3385.cs

@@ -1,5 +1,4 @@
-#if IOS
-using NUnit.Framework;
+using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
 
@@ -16,7 +15,6 @@ public Issue3385(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Entry)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
 		public void Issue3385Test()
 		{
 			App.WaitForElement("entry");
@@ -26,5 +24,4 @@ public void Issue3385Test()
 			App.WaitForNoElement("FAIL");
 		}
 	}
-}
-#endif
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3507.cs

@@ -1,5 +1,4 @@
-#if WINDOWS
-using NUnit.Framework;
+using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
 
@@ -20,9 +19,8 @@ public Issue3507(TestDevice testDevice) : base(testDevice)
 		[Category(UITestCategories.Compatibility)]
 		public void NullContentOnScrollViewDoesntCrash()
 		{
-			App.WaitForNoElement(Success);
+			App.WaitForElement(Success);
 			//if it doesn't crash, we're good.
 		}
 	}
-}
-#endif
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3884.cs

@@ -15,13 +15,10 @@ public Issue3884(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.BoxView)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
-		[FailsOnWindowsWhenRunningOnXamarinUITest]
 		public void Issue3884Test()
 		{
-			App.WaitForElement("TestReady");
-			App.Screenshot("I see a blue circle");
+			App.WaitForElement("You should see a blue circle");
+			VerifyScreenshot();
 		}
 	}
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue5239.cs

@@ -17,11 +17,10 @@ public Issue5239(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Layout)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
 		public void PaddingEqualToSafeAreaWorks()
 		{
 			var somePadding = App.WaitForElement("Hello").GetRect();
-			ClassicAssert.AreEqual(20f, somePadding.Y);
+			Assert.That(20f, Is.EqualTo(somePadding.Y));
 		}
 	}
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue5376.cs

@@ -15,12 +15,9 @@ public Issue5376(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.Entry)]
 		[Category(UITestCategories.Compatibility)]
-		[FailsOnIOSWhenRunningOnXamarinUITest]
-		[FailsOnMacWhenRunningOnXamarinUITest]
-		[FailsOnWindowsWhenRunningOnXamarinUITest]
 		public void Issue5376Test()
 		{
-			App.WaitForNoElement("Success");
+			App.WaitForElement("Success");
 		}
 	}
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue5461.cs

@@ -1,5 +1,4 @@
-#if ANDROID
-using NUnit.Framework;
+using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
 
@@ -20,8 +19,7 @@ public Issue5461(TestDevice testDevice) : base(testDevice)
 		[Category(UITestCategories.Compatibility)]
 		public void ScrollViewWithScrollbarFadingEnabledFalseDoesntCrash()
 		{
-			App.WaitForNoElement(Success);
+			App.WaitForElement(Success);
 		}
 	}
-}
-#endif
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue5555.cs

@@ -13,8 +13,6 @@ public Issue5555(TestDevice device) : base(device)
 
 		[Test]
 		[Category(UITestCategories.TableView)]
-		[FailsOnIOSWhenRunningOnXamarinUITest("This test is failing, likely due to product issue")]
-		[FailsOnMacWhenRunningOnXamarinUITest("This test is failing, likely due to product issue")]
 		public void TableViewMemoryLeakWhenUsingSwitchCellOrEntryCell()
 		{
 			App.WaitForElement("PushPage");

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue6472.cs

@@ -1,4 +1,4 @@
-#if IOS
+#if TEST_FAILS_ON_WINDOWS //application crash while load the listview, for more information: https://github.com/dotnet/maui/issues/27174
 using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;
@@ -21,19 +21,22 @@ public Issue6472(TestDevice testDevice) : base(testDevice)
 		[Test]
 		[Category(UITestCategories.ListView)]
 		[Category(UITestCategories.Compatibility)]
-		[Ignore("Fails occasionally on iOS 12 https://github.com/xamarin/Xamarin.Forms/issues/6472")]
 		public void ListViewDoesNotThrowExceptionWithObservableCollection()
 		{
 			App.WaitForElement(ListViewAutomationId);
-			App.Screenshot("We got here without an exception while loading the data and data is visible");
-
 			App.Tap(ClearButtonAutomationId);
 			App.Tap(UiThreadButtonAutomationId);
+			App.WaitForElement("Just three");
 			App.Tap(OtherThreadButtonAutomationId);
-
+			App.WaitForElement("THE answer");
 			App.Tap(ClearButtonAutomationId);
+			App.WaitForNoElement("Just three");
+			App.WaitForNoElement("THE answer");
 			App.Tap(OtherThreadButtonAutomationId);
+			App.WaitForElement("THE answer");
 			App.Tap(UiThreadButtonAutomationId);
+			App.WaitForElement("Just three");
+
 		}
 	}
 }

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7823.cs

@@ -15,7 +15,6 @@ public Issue7823(TestDevice device)
 
 		[Test]
 		[Category(UITestCategories.ToolbarItem)]
-		[FailsOnMacWhenRunningOnXamarinUITest("VerifyScreenshot method not implemented on macOS")]
 		public void UpdateToolbarItemAfterNavigate()
 		{
 			// 1. Navigate from Page with a ToolbarItem using an Icon.