Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add .editorconfig to Core for specifying CA rules #17411

Merged
merged 3 commits into from
Sep 17, 2023

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Sep 15, 2023

Description of Change

For various reasons, the default code analysis rules have never been fully enforced in this repository. We would like to change that, but turning on all the rules for all projects at once is simply not an option with our current resources.

As an alternative, we can incrementally being enforcing these rules per-project, per-category, per-rule, and per-file via .editorconfig.

While it's tempting to mass-fix violations for a particular rule or category, doing so may generate changes across dozens or even hundreds of files at once. This makes for confusing change histories and conflicts. Instead, we can fix violations in smaller, easily reviewed subsets and prevent future violations in those areas using .editorconfig. By doing this incrementally, we can ratchet up the level of enforcement until we can turn it on for entire projects.

This change adds CA performance rule enforcement for Flex and PlatformTouchGraphicsView.

Add CA performance rule enforcement for Flex, PlatformTouchGraphicsView
Fix CA performance violations for Flex, PlatformTouchGraphicsView
@hartez hartez requested a review from a team as a code owner September 15, 2023 18:01
@hartez hartez requested review from mattleibow and PureWeen and removed request for StephaneDelcroix September 15, 2023 18:07
mattleibow
mattleibow previously approved these changes Sep 15, 2023
@rmarinho rmarinho merged commit fdbeb81 into main Sep 17, 2023
@rmarinho rmarinho deleted the begin-fixing-perf-violations branch September 17, 2023 12:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Aug 2, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants