Port inline completion to cohosting #11277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Dec 6, 2024
| @@ -16,7 +16,7 @@ | |||
| <_MicrosoftCodeAnalysisAnalyzersPackageVersion>3.11.0</_MicrosoftCodeAnalysisAnalyzersPackageVersion> | |||
| <_RoslynDiagnosticAnalyzersPackageVersion>3.11.0-beta1.24508.2</_RoslynDiagnosticAnalyzersPackageVersion> | |||
| <_MicrosoftVisualStudioLanguageServicesPackageVersion>$(MicrosoftVisualStudioLanguageServicesPackageVersion)</_MicrosoftVisualStudioLanguageServicesPackageVersion> | |||
| <_XunitPackageVersion>2.6.6</_XunitPackageVersion> | |||
| <_XunitPackageVersion>2.9.2</_XunitPackageVersion> | |||
There was a problem hiding this comment.
This will be needed once we get the Roslyn bump, but you'll just have to trust me for now
|
|
||
| internal static class SnippetFormatter | ||
| { | ||
| public static bool TryGetSnippetWithAdjustedIndentation(FormattingContext formattingContext, string snippetText, int hostDocumentIndex, [NotNullWhen(true)] out string? newSnippetText) |
There was a problem hiding this comment.
This was moved from InlineCompletionEndpoint with no changes, other than making it public.
DustinCampbell
approved these changes
Dec 6, 2024
...r/src/Microsoft.AspNetCore.Razor.LanguageServer/InlineCompletion/InlineCompletionEndPoint.cs
Show resolved
Hide resolved
...or/src/Microsoft.CodeAnalysis.Remote.Razor/InlineCompletion/RemoteInlineCompletionService.cs
Outdated
Show resolved
Hide resolved
....VisualStudio.LanguageServices.Razor/LanguageClient/Cohost/CohostInlineCompletionEndpoint.cs
Outdated
Show resolved
Hide resolved
...rosoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostInlineCompletionEndpointTest.cs
Show resolved
Hide resolved
alexgav
reviewed
Dec 6, 2024
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Formatting/RazorFormattingOptions.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Tests are failing because logging is happening after a test has finished, which usually means something isn't being disposed properly, but none of the test changes in this PR could cause it, because its happening on macOS and linux, and the test changes here are Windows only. Must be a change in Roslyn :( |
This was referenced Dec 18, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10744
Needs dotnet/roslyn#76293 to merge and a version bump, but you know the idea by now I'm sure.
Pretty straight forward. The test snippet file was copied directly from Roslyns own inline completion tests. Turns out our existing inline completion has zero tests, and was inadvertently turned off in the first cohosting completion PR 🤦♂️