Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prevent warnings from new IVTs from Roslyn #11504

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Prevent warnings from new IVTs from Roslyn #11504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.Common" Version="$(MicrosoftCodeAnalysisWorkspacesCommonPackageVersion)" />
<PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="$(MicrosoftCodeAnalysisWorkspacesMSBuildPackageVersion)" />
<PackageVersion Include="Microsoft.CommonLanguageServerProtocol.Framework" Version="$(MicrosoftCommonLanguageServerProtocolFrameworkPackageVersion)" PrivateAssets="all" />
<PackageVersion Include="Microsoft.CodeAnalysis.LanguageServer.Protocol" Version="$(MicrosoftCodeAnalysisExternalAccessRazorPackageVersion)" />
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
<PackageVersion Include="Microsoft.Css.Parser" Version="1.0.0-20230414.1" />
<PackageVersion Include="Microsoft.DiaSymReader" Version="2.0.0" />
Expand Down
2 changes: 2 additions & 0 deletions ...rosoft.AspNetCore.Razor.Microbenchmarks/Microsoft.AspNetCore.Razor.Microbenchmarks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@
<PackageReference Include="BenchmarkDotNet.Diagnostics.Windows" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
<PackageReference Include="Microsoft.DiaSymReader" />

<PackageReference Include="Microsoft.CodeAnalysis.LanguageServer.Protocol" Aliases="RLSP" />
</ItemGroup>

<Import Project="..\..\..\Shared\Microsoft.AspNetCore.Razor.Serialization.Json\Microsoft.AspNetCore.Razor.Serialization.Json.projitems" Label="Shared" />
Expand Down
8 changes: 8 additions & 0 deletions ...icrosoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,14 @@
Now we aren't sure why this exposes a "flaky" issue; however, to workaround the break we pin the following packages to workaround the issue.
-->
<PackageReference Include="Microsoft.VisualStudio.RpcContracts" />

<!--
Razor and Roslyn both use CLaSP as the basis for their language servers, but CLaSP is a source package
which means when we reference Roslyn's server to get the LSP protocol types (which we have a restricted
IVT to) we get ambiguous type errors for everything in CLaSP. To fix this we reference Roslyn with an
alias, and then have a global using for the LSP protocol types only.
-->
<PackageReference Include="Microsoft.CodeAnalysis.LanguageServer.Protocol" Aliases="RLSP" />
</ItemGroup>

<ItemGroup>
Expand Down
10 changes: 10 additions & 0 deletions ...spNetCore.Razor.LanguageServer.Test/Microsoft.AspNetCore.Razor.LanguageServer.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,14 @@
<EmbeddedResource Include="Semantic\TestFiles\**\*" />
</ItemGroup>

<ItemGroup>
<!--
Razor and Roslyn both use CLaSP as the basis for their language servers, but CLaSP is a source package
which means when we reference Roslyn's server to get the LSP protocol types (which we have a restricted
IVT to) we get ambiguous type errors for everything in CLaSP. To fix this we reference Roslyn with an
alias, and then have a global using for the LSP protocol types only.
-->
<PackageReference Include="Microsoft.CodeAnalysis.LanguageServer.Protocol" Aliases="RLSP" />
</ItemGroup>

</Project>
2 changes: 2 additions & 0 deletions ...spNetCore.Razor.Test.Common.Tooling/Microsoft.AspNetCore.Razor.Test.Common.Tooling.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@
<PackageReference Include="xunit.extensibility.execution" />
<PackageReference Include="Xunit.Combinatorial" />
<PackageReference Include="Xunit.StaFact" />

<PackageReference Include="Microsoft.CodeAnalysis.LanguageServer.Protocol" Aliases="RLSP" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'">
Expand Down