-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade BlazorWasmDebugging to 1.1.3 #8187
Conversation
It's been a while since we've published a new version (currently 1.1.0 is the most recent). Incrementing the version because of the addition of #7929, then will walk through publishing on resolution of this PR. My understanding of the publishing process is from the guide written by @captainsafia [here](https://github.com/dotnet/razor/blob/main/src/Razor/src/Microsoft.AspNetCore.Razor.VSCode.BlazorWasmDebuggingExtension/README.dev.md#publishing-the-extension). Please correct me if this process is no longer correct.
@@ -2,7 +2,7 @@ | |||
"name": "blazorwasm-companion", | |||
"displayName": "Microsoft.AspNetCore.Razor.VSCode.BlazorWasmDebuggingExtension", | |||
"description": "A companion extension for debugging Blazor WebAssembly applications in VS Code. Must be installed alongside the C# extension.", | |||
"version": "1.1.2", | |||
"version": "1.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider aligning this with the O# versioning?
src/Razor/src/Microsoft.AspNetCore.Razor.VSCode.BlazorWasmDebuggingExtension/package.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
@dotnet/razor-tooling can this be merged or are there any specific processes we should follow? |
@TanayParikh I think you merged the last one of these PRs. Do you still have permission? Otherwise I can do it, but I have no context here. I assume good faith and everything is correct :) @allisonchou do you know how this is shipped? |
@davidwengier we have the right permissions, just wanted to make sure we weren't circumventing any process by merging before the tagged code owners saw it. Do you think we should change this to reflect that or would you prefer that razor-tooling is still tagged on PRs here as an FYI? Line 10 in b42d501
As far as publishing goes, this is how I understand it. I figured the repo name is outdated but assumed the rest to be okay. razor/src/Razor/src/Microsoft.AspNetCore.Razor.VSCode.BlazorWasmDebuggingExtension/README.dev.md Lines 25 to 30 in b42d501
|
No issue from me merging this, and updating code owners as appropriate. @phil-allen-msft do you have any thoughts? |
The change seems very reasonable; let's make sure how to discuss testing before release. |
I think having razor-tooling aware that a new publish occurs is appropriate; we may end up seeing logged issues related to BlazorWasm debugging and knowing that 'something' has changed in the BlazorWasm debugging space in particular will help us to route the issues more correctly. I think it should mainly be a quick approve in the future, and I'd rather have natural processes handle it than require people to know/remember to send notice. For now, let's leave the codeowners unchanged. |
It's been a while since we've published a new version (currently 1.1.0 is the most recent). Incrementing the version because of the addition of #7929, then will walk through publishing on resolution of this PR.
My understanding of the publishing process is from the guide written by @captainsafia here. Please correct me if this process is no longer correct.