Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade BlazorWasmDebugging to 1.1.3 #8187

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Upgrade BlazorWasmDebugging to 1.1.3 #8187

merged 2 commits into from
Feb 2, 2023

Conversation

Nick-Stanton
Copy link
Member

It's been a while since we've published a new version (currently 1.1.0 is the most recent). Incrementing the version because of the addition of #7929, then will walk through publishing on resolution of this PR.

My understanding of the publishing process is from the guide written by @captainsafia here. Please correct me if this process is no longer correct.

It's been a while since we've published a new version (currently 1.1.0 is the most recent). Incrementing the version because of the addition of #7929, then will walk through publishing on resolution of this PR.

My understanding of the publishing process is from the guide written by @captainsafia [here](https://github.com/dotnet/razor/blob/main/src/Razor/src/Microsoft.AspNetCore.Razor.VSCode.BlazorWasmDebuggingExtension/README.dev.md#publishing-the-extension). Please correct me if this process is no longer correct.
@Nick-Stanton Nick-Stanton requested a review from a team as a code owner January 27, 2023 23:05
@@ -2,7 +2,7 @@
"name": "blazorwasm-companion",
"displayName": "Microsoft.AspNetCore.Razor.VSCode.BlazorWasmDebuggingExtension",
"description": "A companion extension for debugging Blazor WebAssembly applications in VS Code. Must be installed alongside the C# extension.",
"version": "1.1.2",
"version": "1.1.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider aligning this with the O# versioning?

@TanayParikh TanayParikh requested a review from a team January 28, 2023 00:29
Co-authored-by: Tanay Parikh <TanayParikh@users.noreply.github.com>
@mkArtakMSFT
Copy link
Member

@dotnet/razor-tooling can this be merged or are there any specific processes we should follow?

@davidwengier
Copy link
Contributor

davidwengier commented Feb 1, 2023

@TanayParikh I think you merged the last one of these PRs. Do you still have permission? Otherwise I can do it, but I have no context here. I assume good faith and everything is correct :)

@allisonchou do you know how this is shipped?

@Nick-Stanton
Copy link
Member Author

@davidwengier we have the right permissions, just wanted to make sure we weren't circumventing any process by merging before the tagged code owners saw it.

Do you think we should change this to reflect that or would you prefer that razor-tooling is still tagged on PRs here as an FYI?

/src/Razor/src/Microsoft.AspNetCore.Razor.VSCode.BlazorWasmDebuggingExtension/ @dotnet/razor-tooling @captainsafia

As far as publishing goes, this is how I understand it. I figured the repo name is outdated but assumed the rest to be okay.

1. Generate a personal access token per the instructions in [the VS Code publishing guide](https://docs.microsoft.com/en-us/azure/devops/organizations/accounts/use-personal-access-tokens-to-authenticate?view=azure-devops&tabs=preview-page).
2. Store the token from #1 in the `VSCODE_MARKETPLACE_TOKEN` environment variable.
3. Increment the `patch` version of the package in the `package.json` file.
4. Open a PR to the razor-tooling repo.
5. Download the VSIX asset from the artifiacts of the build.
6. Publish the VSIX asset using `vsix publish --packagePath ${pathFrom5} -p $VSCODE_MARKETPLACE_TOKEN`.

@davidwengier
Copy link
Contributor

No issue from me merging this, and updating code owners as appropriate. @phil-allen-msft do you have any thoughts?

@phil-allen-msft
Copy link
Contributor

The change seems very reasonable; let's make sure how to discuss testing before release.

@phil-allen-msft
Copy link
Contributor

I think having razor-tooling aware that a new publish occurs is appropriate; we may end up seeing logged issues related to BlazorWasm debugging and knowing that 'something' has changed in the BlazorWasm debugging space in particular will help us to route the issues more correctly. I think it should mainly be a quick approve in the future, and I'd rather have natural processes handle it than require people to know/remember to send notice. For now, let's leave the codeowners unchanged.

@Nick-Stanton Nick-Stanton merged commit a375ad2 into main Feb 2, 2023
@Nick-Stanton Nick-Stanton deleted the Nick-Stanton-1.1.3 branch February 2, 2023 22:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants