Handle UnauthorizedAccessExceptions in DirectoryHelper #8219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When recursively digging through directories to find project configuration files (i.e. `project.razor.json`), we didn't handle any `UnauthorizedAccessExceptions` that might be thrown. So, if some sub-directory fails due to permissions access, the entire search would fail, even if a configuration file had already been found.
davidwengier
approved these changes
Feb 5, 2023
ryanbrandenburg
approved these changes
Feb 6, 2023
| @@ -128,14 +118,18 @@ protected virtual void OnInitializationFinished() | |||
| // Protected virtual for testing | |||
| protected virtual IEnumerable<string> GetExistingConfigurationFiles(string workspaceDirectory) | |||
| { | |||
| var files = DirectoryHelper.GetFilteredFiles(workspaceDirectory, _languageServerFeatureOptions.ProjectConfigurationFileName, s_ignoredDirectories, logger: _logger); | |||
| using var _ = _logger.BeginScope("Searching for existing project configuration files"); | |||
There was a problem hiding this comment.
Probably want to merge #8233 first or cherry-pick it onto this PR.
It was silly of me to write it that way at the time just because we weren't using Scopes yet.
There was a problem hiding this comment.
Also of note though, most of the loggers NoOp for BeginScope, so this might not produce the useful info you imagine (though it will be nice to "come online" if we complete #8232).
maryamariyan
added a commit
that referenced
this pull request
Jul 20, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recursively digging through directories to find project configuration files (i.e.
project.razor.json), we didn't handle anyUnauthorizedAccessExceptionsthat might be thrown. So, if some sub-directory fails due to permissions access, the entire search would fail, even if a configuration file had already been found.Beyond the bug fix (which is small), I did a bit of clean up.