Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix NGEN By Moving EditorSettings Back To Workspaces Layer #8282

Merged
merged 3 commits into from
Feb 18, 2023
Merged

Fix NGEN By Moving EditorSettings Back To Workspaces Layer #8282

merged 3 commits into from
Feb 18, 2023

Conversation

ryzngard
Copy link
Contributor

No description provided.

@ryzngard ryzngard requested a review from a team as a code owner February 15, 2023 20:01
@RikkiGibson
Copy link
Contributor

If this change is not ready to merge, could we try queueing an official build of it internally to see if it resolves our RPS issues?

@ryzngard
Copy link
Contributor Author

@RikkiGibson running https://dev.azure.com/dnceng/internal/_build/results?buildId=2117268&view=results

davidwengier
davidwengier approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think web tools references EditorSettingsManager too, at least on Mac, but we should probably unblock RPS :)

@ryzngard
Copy link
Contributor Author

Thank you! I think web tools references EditorSettingsManager too, at least on Mac, but we should probably unblock RPS :)

They do, but EditorSettingsManager didn't move layers. This is why it was weird to me... it's split across things and I thought unifying would make life better. Oh was I wrong

@ryzngard ryzngard enabled auto-merge (squash) February 18, 2023 06:03
@ryzngard ryzngard merged commit df8e6ae into dotnet:main Feb 18, 2023
@ryzngard ryzngard deleted the fix_ngen branch February 18, 2023 07:26
@davidwengier
Copy link
Member

oh.. weird.. let me kick off a VS Mac insertion to test, maybe i'm misremembering

@davidwengier
Copy link
Member

Okay, VS Mac is mostly happy now. Complaining about a new reference to VS shell framework, which doesn't ship on mac, but haven't looked where that is coming from yet.

@allisonchou allisonchou mentioned this pull request Feb 23, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryzngard @RikkiGibson @davidwengier