Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update contributing docs #8301

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Update contributing docs #8301

merged 1 commit into from
Feb 22, 2023

Conversation

jjonescz
Copy link
Member

Fixes #5996.

  • Replaced references to razor-tooling with razor.
  • Updated "Debugging with experimental Roslyn bits" to what actually worked for me.

@jjonescz jjonescz marked this pull request as ready for review February 21, 2023 17:10
```xml
<packageSource key="Roslyn Local Package source">
<package pattern="microsoft.*" />
<package pattern="microsoft.commonlanguageserverProtocol.*" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely the microsoft.* pattern covers this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but isn't it still redundant having both for the same package source?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. I started with just microsoft.*, but then NuGet complained that Microsoft.CommonLanguageServerProtocol.Framework cannot be found, because it was trying to find it in different source. Adding that pattern is what worked for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see. That makes sense actually, because I just checked and there are other groups that are that specific, so if you want to override you'd have to be as specific. Thanks!

@jjonescz jjonescz merged commit 478e83f into dotnet:main Feb 22, 2023
@jjonescz jjonescz deleted the 5996-docs branch February 22, 2023 08:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Razor Compiler Docs
3 participants