Add support for threading MSBuild item metadata to analyzer options #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses analyzer part of dotnet/sdk#12706 Adds support for platform compat check analyzer to be able to read `SupportedPlatform` items.
buyaa-n
approved these changes
Aug 4, 2020
src/Tools/GenerateGlobalAnalyzerConfigs/GenerateGlobalAnalyzerConfigs.csproj
Show resolved
Hide resolved
mavasani
commented
Aug 4, 2020
Co-authored-by: Buyaa <buyankhishig.namnan@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #3950 +/- ##
==========================================
- Coverage 95.64% 95.63% -0.01%
==========================================
Files 1153 1155 +2
Lines 254404 254759 +355
Branches 15242 15252 +10
==========================================
+ Hits 243326 243649 +323
- Misses 9139 9161 +22
- Partials 1939 1949 +10 |
|
Thanks @buyaa-n! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses analyzer part of dotnet/sdk#12706
Adds support for platform compat check analyzer to be able to read
SupportedPlatformitems.Analyzers should invoke
context.Options.GetMSBuildItemMetadataValuesextension method to query this option.User project file
Analyzer options with item metadata